dakboard / Cloud-Platform

Feature requests, enhancements and anything you'd like to see in DAKboard!
https://dakboard.com
164 stars 39 forks source link

Agenda Calendar Days to Show limit incorrect. #2025

Closed rsalsbery closed 5 months ago

rsalsbery commented 5 months ago

We found that under very specific circumstances, the Agenda calendar can show events as far out as next year. This happens because the calendar can be set to show up to 90 events and not 90 days.

Steps to replicate:

For users who want to hide all past events, this can be confusing because the calendar may show events from the following year.

The Days to Show should be the limit to the number of days from the current day and not the number of events to show.

Dan-Peck commented 5 months ago

After further analysis and discussion, it was found that:

ICS data something like this will cause the event to appear a year ahead, when it should not:

BEGIN:VEVENT
.
.
.
RRULE:FREQ=YEARLY;UNTIL=20250119T050000Z;INTERVAL=1;BYMONTHDAY=19;BYMONTH=1
DTSTART;VALUE=DATE:20240119
DTEND;VALUE=DATE:20240120
.
.
.
END:VEVENT

Cause of the issue has been found and a change to remedy this behavior is underway.

Dan-Peck commented 5 months ago

Merged in @ 271331b and added to the queue for upcoming release to the live site.