dakboard / Cloud-Platform

Feature requests, enhancements and anything you'd like to see in DAKboard!
https://dakboard.com
168 stars 39 forks source link

Issues with Sunrise and Sunset in block scheduler. #2033

Closed rsalsbery closed 9 months ago

rsalsbery commented 9 months ago

It appears when you use the block scheduler and the Sunrise and Sunset options, they run in reverse of what you would expect.

Steps to reproduce the behavior:

  1. Add a block to a screen
  2. Set the block Scheduler to start at Sunrise and end

This should make it so that the block is visible from Sunrise to Sunset

image

When you reverse it and set it to Sunset to start and Sunrise to end, it will show properly. The Scheduled Text Block, Seen below Looks to be working properly on the Editor page, but when viewed on the Screen you get the reverse:

Configuration: image

Screen Editor: image

Screen in View mode: image

We found that this was due to a misplaced statement controlling the Tomezone translation.

Dan-Peck commented 9 months ago

Dev Notes: header-common, date_default_timezone_set()

RichyRich1970 commented 9 months ago

TY for the efforts to resolve this - I was the one who found it and opened a bug report with DAKBoard this morning. I'm brand new to DAKBoard, just a few days into it, but loving it and looking forward to how we will use it for putting up dynamic boards at our Short Term Rental properties! - Rich

Dan-Peck commented 9 months ago

Merged in @ cf7b9f3 and added to the queue for upcoming release to the live site.