Calendar entries that end at midnight show at the top of the list instead of the bottom

[timjrobinson]

Describe the bug I work nights from 7pm -> 4am. There is a persistent bug where calendar entries that end at Midnight will show at the beginning of each day instead of the end of each day.

I believe this is because it's sorting entries by the end time and in 24 hour mode the end time is 0:00

To Reproduce Steps to reproduce the behavior:

1. Create a calendar widget on your DAKBoard Dashboard, syncing from Google Calendar
2. Add a calendar entry starting at 23:30 and ending at midnight.
3. Add another calendar entry for any time during the day

Expected behavior I expect that a calendar entry at the very end of the day should be at the bottom of the events list. Currently it appears at the top.

Screenshots

This is a photo of my monitor showing the Dakboard .

The event "All Hands" should be at the end of Monday. The event "Chad Fowler and ..." should be at the end of Tuesday.

Desktop (please complete the following information):

• OS: DAKOS Release 3.42

[Dan-Peck]

After some analysis, it was found that such events are being treated as "multi-day" events due to its end time technically falling on "the next day" (i.e., midnight). This, in turn, caused the event to be moved up to the top section, and background-colored in the two monthly calendar types.

Multi-day detection and processing can be modified to account for this scenario. We will need to check and ensure events from all possible calendar sources (Google, MS, iCal) are covered, as well as the rendering of each calendar type and mode.

[Dan-Peck]

Server Update Reminder

• Upon release, as this may have a short time window where some events will be treated as non-multiday until their cache data is renewed with updated data, we will want to release this during off-peak hours to minimize the impact

[Dan-Peck]

Merged in @ aa9a6f4 and added to the queue for upcoming release to the live site.