Closed dakk closed 3 months ago
Hi @dakk I have done a QPE Algo
Hi @AbdullahKazi500 , thank you for your contribution. Can you show me an example of use-case for the algo using a qlasskit function?
Anyway, the algorithm should be implemented in the algorithms module; the notebook is only a showcase of the algorithm. Before writing more code, please answer the question above.
hi @dakk I can possibly try but since QPE is an advance and complex algo I dont know if we can extend it to a use case given qlasskit is in a beta stage do you want me to try it out
in my notebook I have given a basic demo of the QPE circuit using qlasskit function
hi @dakk I can possibly try but since QPE is an advance and complex algo I dont know if we can extend it to a use case given qlasskit is in a beta stage do you want me to try it out
Yes, try it out.
in my notebook I have given a basic demo of the QPE circuit using qlasskit function
In your notebook you just the QAlgorithm of QPE, you're not using it. You should instead put the QAlgorithm implementation in a proper file in the algorithms module, while put a demo in the notebook.
But before writing more code, please show me an example of use-case for the algo using a qlasskit function, so I can determine in the algorithm you proposed is suitable for qlasskit.
ok Suppose we have a simple quantum circuit that applies a single-qubit gate U to an ancillary qubit in the state ∣+⟩, where U is a phase gate with an unknown phase θ. We want to estimate this phase θ. this is a basic use case @dakk
ok Suppose we have a simple quantum circuit that applies a single-qubit gate U to an ancillary qubit in the state ∣+⟩, where U is a phase gate with an unknown phase θ. We want to estimate this phase θ. this is a basic use case @dakk
Ok thanks; I'm sorry but I don't think QPE meets the issue requirements. Thank you for the proposal anyway!
so can I Add my algorithm in the algorithm module and will it be considered for a bounty @dakk I can experiment with other advance algorithms as well if Have some time
No, I'm sorry but the requirements should be met in order to solve the issue. Anyway, if you have any other proposal let me know!
ok @dakk you need a use case right ?
Yes, like I did for Grover search; in the use case, I used Grover implemented inside qlasskit, in order to search for a solution of an oracle. This oracle is built using qlasskit, for example searching for a sudoku puzzle solution.
https://dakk.github.io/qlasskit/example_grover_sudoku.html
Like I did for Grover, the final work of the issue should include:
Hey, I have made a PR and it got successfully merged.
Thank you divshacker for the contribution!
qlasskit.algorithms
package.qlassf
functions.The code of the pull request should include:
Please read CONTRIBUTING.md before contributing.