dakk / tezpool

Tezos baking redistribution software
https://dakk.github.io/tezpool/
MIT License
23 stars 6 forks source link

Pending rewards always remain at 0 #3

Closed ericlavoie closed 6 years ago

ericlavoie commented 6 years ago

You seem to have an error in the differentiation with pending versus deposit frozen.

dakk commented 6 years ago

The "pending" value is the baked reward after 7 frozen cycles The "frozen" value si the baked reward still frozen The "paid" value is the pending value already sent to delegators

ericlavoie commented 6 years ago

check http://tzscan.io/tz1SohptP53wDPZhzTWzDUFAUcWF6DMBpaJV?default=rewards

for cycle 14 the output is the following: Estimated = 12 (its fine) Frozen = 12 (that is incorrect, it should be 84 if it is deposits, otherwise there is no need for pending) Pending = 0, (it should be 12) Paid reward = 0 (correct) (tzscan uses deliverred) This terminology is the one used by tzscan.

ericlavoie commented 6 years ago

Also could the output allow filtering for one specific key?

dakk commented 6 years ago

frozen is not the deposit; it's the reward not yet mature

ericlavoie commented 6 years ago

This causes confusion, the reference seems to be tzscan, and frozen is reward pending, estimated is equivalent to pending. You do not show pending value at any cycle, paid reward is not there either, but reward is, this is way too mixed or rather not consistent across your interface.

dakk commented 6 years ago

Tzscan it's not a pool and doesn't include pending reward to be redistributed and paid reward to deleguees; anyway I put a small dictionary in the readme: https://github.com/dakk/tezpool#terms

You can modify these words for your pool in the docs/index.html

ericlavoie commented 6 years ago

Actually tzscan shows delegates payments, and pending reward distribution see http://tzscan.io/tz1SohptP53wDPZhzTWzDUFAUcWF6DMBpaJV?default=rewards