daknam2001 / pe

0 stars 0 forks source link

'X' should not be at the end of the activation bar. #18

Open daknam2001 opened 2 years ago

daknam2001 commented 2 years ago

image.png

'X' should not be at the end of the activation bar. There is no destructor is java. 'X' should be slightly further down in the lifeline to signify that the object is no longer being referenced.

soc-se-bot commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Sequence diagram "X" issue

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.


I think a "X" should be put when the object is destructed not the return of a method? Screenshot 2021-11-12 at 5.29.09 PM.png


[original: nus-cs2113-AY2122S1/pe-interim#2442] [original labels: severity.High type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

I think this should be correct though because the object is deleted.

Change severity to Low :

Does not affect the diagram greatly.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I don't think the 'X' should be on the activation bar.


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]