Fix speed-type-top-x Showing Only Headers

LaurenceWarne commented 2 years ago

Hi, whilst testing stuff some stuff in my other PR I encountered some strange behaviour with speed-type-top-x, namely the speed type buffer would be filled with the response headers from the HTTP request used to fetch the x most popular words.

This PR fixes that using url-http-end-of-headers and write-region (at least for me locally).

A couple of other changes:

I've switched out url-retrieve for url-retrieve-synchronously since speed-type--retrieve was blocking until it received a result anyway
I've also set the type property of the custom variable speed-type-default-lang to be a choice of const so users can only select languages in speed-type-wordlist-urls

Hope this is helpful (the diff at least is less egregious :slightly_smiling_face:), thanks.

dakra commented 2 years ago

Thanks. This probably came in with https://github.com/dakra/speed-type/pull/28 which I just tested quickly and worked for me in a short test. Using url-retrieve-synchronously makes sense though.

dakra commented 2 years ago

I merged but somehow some tests failed for me now. Maybe you can have a look if you get a chance. Thanks again

LaurenceWarne commented 2 years ago

I merged but somehow some tests failed for me now. Maybe you can have a look if you get a chance. Thanks again

Apologies, I didn't notice there were any tests :slightly_smiling_face:, hopefully this should be fixed by https://github.com/dakra/speed-type/pull/36.

dakra / speed-type

Fix speed-type-top-x Showing Only Headers #35