dakra / speed-type

Practice touch/speed typing in emacs
GNU General Public License v3.0
137 stars 19 forks source link

inherit the colors for correct and mistake faces from success and warning respectively #40

Closed yilkalargaw closed 1 year ago

yilkalargaw commented 1 year ago

Since there is a huge variance in the visibility of green and red in various themes it might be better to inherit the colors for speed-type-correct and speed-type-mistake from the the success and warning faces which are usually set by the theme being used. The reason to not inherit from them directly from those faces was in-case the theme does something weird like using a different weight or having boxes etc...

dakra commented 1 year ago

Thanks. On my theme (moe-theme) I like (face-foreground 'error) better than 'warning for speed-type-mistake because that's red while warning is orangy.

But I didn't test with any other theme so I don't have too strong of an opinion but personally I would prefer 'error just because it looks better for me. WDYT?

yilkalargaw commented 1 year ago

To be frank i forgot about error. That would be better. I'll make the changes.

dakra commented 1 year ago

:pray: Thanks