search

dakrone / clj-http

An idiomatic clojure http client wrapping the apache client. Officially supported version.
http://clojars.org/clj-http
MIT License
1.78k stars 408 forks source link

README example for build-async-http-client (with async conn manager) is wrong #523

Open ejschoen opened 4 years ago

ejschoen commented 4 years ago

The example code shows passing false for the proxy-ignore-hosts parameter. It looks like it should be an empty sequence; else this is an exception: java.lang.IllegalArgumentException: Don't know how to create ISeq from: java.lang.Boolean exception from under clj-http.core/get-route-planner.

dakrone commented 4 years ago

@ejschoen thanks for noticing this, would you be able to open a PR for fixing this?

ejschoen commented 4 years ago

Done. #524.

wmatson commented 4 years ago

531 fixes this a little differently (I ended up dropping the proxy params because they were optional).

wmatson commented 4 years ago

531 has been merged