search

dakrone / clj-http

An idiomatic clojure http client wrapping the apache client. Officially supported version.
http://clojars.org/clj-http
MIT License
1.78k stars 408 forks source link

Properly handle "308 Permanent Redirect" status code #554

Closed kachayev closed 4 years ago

kachayev commented 4 years ago

Based on https://tools.ietf.org/html/rfc7538#section-3, "308 Permanent Redirect" status code is a permanent counterpart of status code 307 thus should be handled similarly.

johnjelinek commented 4 years ago

@dakrone: has this been released? I'm having difficulty getting this to work. My 308 response doesn't follow the Location with :redirect-strategy :lax on an HTTPS POST

dakrone commented 4 years ago

@johnjelinek this has not yet been released, it should go out in the next release though.

johnjelinek commented 4 years ago

Excellent. In the meantime, I'll pin the sha.

johnjelinek commented 4 years ago

oh 😢 looks like I can't use clj-http with deps and git sha because it's a lein project. Any idea when the next release ships?

rymndhng commented 4 years ago

@dakrone I can prepare a new release with this change.

rymndhng commented 3 years ago

@johnjelinek I released 3.10.3 which should have this change in.