Unable to add cookies to the cookie store

dakrone / clj-http

An idiomatic clojure http client wrapping the apache client. Officially supported version.

MIT License

1.77k stars 408 forks source link

I'm trying to manually add a cookie to a cookie store, but I'm running into some problems.

Running the following code results in an empty set

(def my-cookie-store (clj-http.cookies/cookie-store))
(clj-http.cookies/add-cookie my-cookie-store (clj-http.cookies/to-basic-client-cookie ["foo" {:value "bar"}]))
(clojure.pprint/pprint (clj-http.cookies/get-cookies my-cookie-store))

=> {}

Whilst running the following results in the expected set of 1 cookie.

(def my-cookie-store (clj-http.cookies/cookie-store))
(clj-http.cookies/add-cookie my-cookie-store (org.apache.http.impl.cookie.BasicClientCookie2. "foo" "bar"))
(clojure.pprint/pprint (clj-http.cookies/get-cookies my-cookie-store))

=> {"foo" {:discard true, :secure false, :value "bar", :version 0}}

Am I using the add-cookie, or to-basic-client-cookie, wrong? Because as far as I understand the source code, both versions of my code should achieve the same results.

user=> (def c (clj-http.cookies/to-basic-client-cookie ["foo" {:value "bar"}])) #'user/c user=> (.isExpired c (new java.util.Date)) true user=> (def d (org.apache.http.impl.cookie.BasicClientCookie2. "foo" "bar")) #'user/d user=> (.isExpired d (new java.util.Date)) false user=> (.getExpiryDate c) nil user=> (.getExpiryDate d) nil user=>

dakrone / clj-http

Unable to add cookies to the cookie store #600