search

dakrone / clj-http

An idiomatic clojure http client wrapping the apache client. Officially supported version.
http://clojars.org/clj-http
MIT License
1.77k stars 408 forks source link

Update deps #607

Closed ghaskins closed 1 year ago

ghaskins commented 2 years ago

Signed-off-by: Greg Haskins greg@manetu.com

dakrone commented 2 years ago

@ghaskins this appears to break the tests, can you take a look? It appears to be related to the ring.util.codec namespace.

ghaskins commented 2 years ago

@dakrone looking

ghaskins commented 2 years ago

Sorry I had missed the note on how to run 'lein all test' and only checked 'lein test'. The problem seems to be isolated to the :1.6 profile. Investigating now.

ghaskins commented 2 years ago

It seems that the simplest solution is to simply drop the 1.6 profile, as ring-codec only profiles as far back as 1.8. Of course, I don't know what your users require, so this may not be a practical suggestion.

According to https://en.wikipedia.org/wiki/Clojure#Language_overview

1.6 came out 3/2014 and 1.7 6/2015, so setting the floor at 1.7 is probably not terrible. What do you think @dakrone ?

ghaskins commented 2 years ago

I added dropping 1.6 to the proposal. Let me know if you want to take a different route and happy to oblige.