search

dakrone / clj-http

An idiomatic clojure http client wrapping the apache client. Officially supported version.
http://clojars.org/clj-http
MIT License
1.77k stars 408 forks source link

feat(xml): Adding support for XML response body parsing. #630

Closed elliotcourant closed 1 year ago

elliotcourant commented 1 year ago

This adds support for parsing text/xml response bodies using the clojure.xml library. It also implements the auto multimethod for it.

This was something I was trying to do outside of this library but since the response body parsing was already built nicely as a multimethod system inside clj-http I figured I'd try to throw a PR up just incase?

Thank you very much for the great library!

dakrone commented 1 year ago

Merged this, thanks for contributing!

dosbol commented 10 months ago

@dakrone are you planning to release these changes soon?

dakrone commented 10 months ago

@dosbol I didn't have one planned yet, would it be helpful to cut a new release?

raszi commented 2 weeks ago

This change introduced a reflection warning:

Reflection warning, clj_http/client.clj:479:26 - call to method parse on javax.xml.parsers.SAXParser can't be resolved (argument types: unknown, unknown).