dakrone / es-mode

An Emacs major mode for interacting with Elasticsearch
GNU General Public License v3.0
196 stars 34 forks source link

es-goto-next-request should return t I believe #24

Closed ahungry closed 8 years ago

ahungry commented 8 years ago

For the prefix mode of es-execute-request-dwim, it doesn't seem to iterate in the while loop, unless es-goto-next-request returns t (true) as the final evaluation.

Updating as such causes the program to work as expected (although I'm not a fan of it making a new buffer for each request in this case, vs just sharing the same buffer and appending output)

dakrone commented 8 years ago

@ahungry thanks for bringing this up, I might have just broken this with my push from yesterday, I'll take a look.

Really, I need to add tests for this :)

dakrone commented 8 years ago

@ahungry I pushed a new commit for this, can you check it out and see if it's working for you? (I tested locally and it seems to work for me)

ahungry commented 8 years ago

it works!

dakrone commented 8 years ago

Awesome, I will close this then, thanks for reporting!