search

dakrone / es-mode

An Emacs major mode for interacting with Elasticsearch
GNU General Public License v3.0
195 stars 34 forks source link

adds search-match-all snippet #53

Closed FrancescElies closed 7 years ago

FrancescElies commented 7 years ago

Hi,

this PR would add a snippet search match all.

dakrone commented 7 years ago

Merged this, thanks!

I think in the future I'm going to go with a more composable set of snippets, for example, check out https://github.com/dakrone/es-mode/blob/61a8bf7d6cc6881e5555922eb36eecc6733a2b87/snippets/es-mode/search and https://github.com/dakrone/es-mode/blob/61a8bf7d6cc6881e5555922eb36eecc6733a2b87/snippets/es-mode/multi_match

So you can type _search and hit tab (or hit C-c s) and then immediately type multi_match and hit tab again to get a full query, this will be nicer because queries are used all over the place, so it's nice to be able to insert only the part that is desired.

FrancescElies commented 7 years ago

That sounds like a good idea, I'll follow that pattern on the next snippets to come. Thanks!