search

dakrone / lein-bikeshed

A Leiningen plugin designed to tell you your code is bad, and that you should feel bad
176 stars 23 forks source link

cljs files are not taken in accounts #16

Closed BenjaminVanRyseghem closed 9 years ago

BenjaminVanRyseghem commented 10 years ago

Steps to reproduces:

$ lein new cljs-kickoff test
$  echo '(defn looooonnnnng "I am definitely a very long line just to make bikeshed fails hopefully" [arg1 arg2 arg3 arg4] "FAIL")' >> test/src/cljs/test/client.cljs

It appends a 122 characters long line in client.cljs

Running bikeshed gives the following output:

$ lein bikeshed   
Compiling ClojureScript.
Compiling "resources/public/js/cljs.js" from ["src/cljs"]...
Successfully compiled "resources/public/js/cljs.js" in 10.659 seconds.

Checking for lines longer than 80 characters.
No lines found.

Checking for lines with trailing whitespace.
No lines found.

Checking for files ending in blank lines.
No files found.

Checking for redefined var roots in source directories.
No with-redefs found.

Checking whether you keep up with your docstrings.
0/4 [0.00%] functions have docstrings.
Use -v to list functions without docstrings
dakrone commented 10 years ago

I took a look at this, it looks like this is because src/cljs is not actually part of leiningen's :source-paths, I will try to detect the :source-paths from the cljsbuild plugin.

BenjaminVanRyseghem commented 9 years ago

Hey :smile:

Any progress on this issue? :smiley_cat:

dakrone commented 9 years ago

I haven't started it yet, but I'd be happy to take a pull request if you wanted to take a look at it!

BenjaminVanRyseghem commented 9 years ago

I will then ;)

Not sure I can help a lot, but I can do my best :smile:

BenjaminVanRyseghem commented 9 years ago

Fix provided :smile: