daksh2k / Spicetify-stuff

Some spicetify extensions!
https://daksh2k.me/Spicetify-stuff/
MIT License
208 stars 25 forks source link

[Bug]: Automatically closing fullscreen #126

Closed JxxIT closed 11 months ago

JxxIT commented 11 months ago

🔍 Have you checked that you are using an auto updating method or latest version of the extension?

🔍 Is there already an issue for your problem?

Choose the extension for bug report.

Full Screen Mode

ℹ Environment / Computer Info

Spotify for macOS (Apple Silicon)
1.2.26.1187.g36b715a1
Spicetify v2.28.1
Theme: Default Dynamic / Base
Extensions: section-marker.js, beautiful-lyrics.js, fullScreenWrapper.js, adblock.js, default-dynamic.js, Vibrant.min.js
Custom apps: marketplace, eternal-jukebox, lyrics-plus

📝 Description

Steps to reproduce:

  1. Make sure that spotify is in fullscreen
  2. Open tv or default mode.
  3. Press esc or exit full screen.
  4. See that spotify is no longer in fullscreen.

📸 Screenshots

No response

daksh2k commented 11 months ago

The purpose of the extension is not to make the default spotify window fullscreen, it's to provide a different experience when using this extension. "full screen" is the name of the extension, The esc key is used to exit this extension/ full screen

JxxIT commented 11 months ago

Yeah I understand, but when you hit the esc key or close the extension, spotify automatically closes fullscreen.

daksh2k commented 11 months ago

Oh if you are using mac and by default use spotify in full screen state, you can just turn this setting off, it won't change your behaviour when entering and exiting this extension.

image
JxxIT commented 11 months ago

Oh yeah, that fixes it.