[Bug]: High CPU usage when using Full Screen

daksh2k / Spicetify-stuff

Some spicetify extensions!

https://daksh2k.me/Spicetify-stuff/

MIT License

197 stars 24 forks source link

[Bug]: High CPU usage when using Full Screen #151

Closed ameliorability closed 6 months ago

ameliorability commented 6 months ago

🔍 Have you checked that you are using an auto updating method or latest version of the extension?

[X] I have checked that I am on the latest version.

🔍 Is there already an issue for your problem?

[X] I have checked older issues, open and closed

Choose the extension for bug report.

Full Screen Mode

ℹ Environment / Computer Info

Spotify for Linux (Flatpak) (Fedora) version 1.2.31.1205.g4d59ad7c
Spicetify v2.33.2
Extensions: trashbin.js
Custom Apps: marketplace, lyrics-plus

📝 Description

Excessively high CPU usage when using Full Screen. This was not an issue in the past, but occurs in the latest FAD update. Occurs in both TV and full screen mode.

Steps: just open Full Screen

That being said, great extension and thank you for making it. I have been using it for several months, it looks so good!

📸 Screenshots

When using FAD

When not using FAD

nxtalex commented 6 months ago

same, hopefully get solved soon

daksh2k commented 6 months ago

I think the issue is because of lyrics-plus, can you disable lyrics from the settings and see if it fixes the issue for now? I confirmed on my machine the issue is lyrics, also you can check by going to lyrics from the sidebar, the CPU consumption skyrockets. Meanwhile, report the issue here https://github.com/spicetify/spicetify-cli/issues, as I have no control over the lyrics.

nxtalex commented 6 months ago

I think the issue is because of lyrics-plus, can you disable lyrics from the settings and see if it fixes the issue for now? I confirmed on my machine the issue is lyrics, also you can check by going to lyrics from the sidebar, the CPU consumption skyrockets. Meanwhile, report the issue here https://github.com/spicetify/spicetify-cli/issues, as I have no control over the lyrics.

yep, problem is indeed with the lyrics. but i found out the cpu usage is very high also with songs without any lyrics, i think you could sligthly update the code and automatically disable lyrics not just in the ui but in the actual program so that at least it does not use high cpu when there are no lyrics. thanks bro

ameliorability commented 6 months ago

Thanks for the input, lyrics-plus is indeed the culprit but WHEN used with full screen. Using lyrics-plus:

CPU usage spikes when lyrics-plus is being used. Thank you for the help and for the wonderful extension.