dakshsinghrathore / Brighter-Beginnings

Discover coding for beginners in our GitHub repo! Enjoy a free three-module course, an interactive learning experience, and a supportive community. Your journey to a brighter future starts now! Join us!
https://brighter-beginnings.vercel.app
MIT License
29 stars 55 forks source link

BUG: On scrolling the visibility of nav bar is bad #77

Closed siwamsingh closed 7 months ago

siwamsingh commented 8 months ago

Is there an existing issue for this?

What happened?

The visibility of the current nav bar is very bad

Comment if you are interested in working on this issue . Mention how you are going to fix this issue . Optional : If possible provide a example like a screenshot , short video or a figma design.

Record

siwamsingh commented 8 months ago
Screenshot 2024-01-07 020719
annu933 commented 8 months ago

@siwamsingh please assign me this issue please

dakshsinghrathore commented 8 months ago

@annu933 assigned, kindly drop a star on this repo HAPPY CODING !

siwamsingh commented 8 months ago

@annu933 can you tell how do you plan to improve the nav bar ?

annu933 commented 8 months ago

@siwamsingh This is of my plan to improving navbar

  1. layout of navbar divide into three col: 1. logo 2. about, services, blog 3. login and register buttons
  2. to show active tab, use theme color to button or add underline below menus
  3. change the background color-white and text-black to navbar on scroll
  4. add hover effect by using theme color

Please let me know If any changes

annu933 commented 8 months ago

@siwamsingh something like this for on scroll Screenshot (7)

siwamsingh commented 8 months ago

@annu933 nice design go forward with it 🙂 Make sure changes are in all pages

annu933 commented 8 months ago

@siwamsingh sir please review my PR https://github.com/dakshsinghrathore/Brighter-Beginnings/pull/92

dakshsinghrathore commented 8 months ago

@annu933 add some spacing in between the nav items, also modules m1 and m2 have the former navbar, kindly look into it.

image

annu933 commented 8 months ago

@dakshsinghrathore sir, maintained the spacing between nav items and added navbar in services page. I have an doubt Is this the same module where I have to add updated navbar and Do I have to add navbar in register page also. Screenshot (12)

annu933 commented 8 months ago

@dakshsinghrathore sir Do I have to replace login and register button to user icon ?

Screenshot (13)

Shaba1406 commented 8 months ago

@dakshsinghrathore Please have a look