search

dakshsinghrathore / ISRO-web

This website aims to adapt SpaceX's official website by incorporating ISRO's content, offering a unique fusion of both organizations.
https://dsr-isrowebapp.netlify.app/
MIT License
42 stars 61 forks source link

[FEAT]: Create Snap scrolling on homepage #22

Closed dakshsinghrathore closed 1 year ago

dakshsinghrathore commented 1 year ago

I'd like to incorporate a snap scrolling effect into the ISRO-web homepage. Here's a brief demonstration of the effect I'm aiming for. Please don't hesitate to reach out if you need any assistance! 🙌🏽

screen-recorder-fri-oct-06-2023-12-57-14.webm

github-actions[bot] commented 1 year ago

Congratulations, @dakshsinghrathore! 🎉 Thank you for creating your issue. Your contribution is greatly appreciated and I look forward to work with you to resolve the issue. Keep up the great work!

I will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check my contributing guidelines

sidhartha2002 commented 1 year ago

Hey Bro, your website looks quite awesome 👍. If you assign me this issue by doing the needful I will greatly appreciate. Thanks

dakshsinghrathore commented 1 year ago

Assigned to you !!

sidhartha2002 commented 1 year ago

I tried implementing snap-scroll on your web page, and I've encountered some technical challenges during the process. Despite my best efforts, the changes I've made seem to be causing issues that affect the overall functionality of the webpage. I'm committed to delivering quality work, but it seems like this specific task might require expertise in a particular area of web development that I currently lack. I believe it would be best to reassign this task to someone who can address these challenges more effectively. Btw thanks for giving me the opportunity.

rohits-web03 commented 1 year ago

Hello! I would love to contribute to your project for the issue #22.

I have implemented the snap-scroll effect on the ISRO-web homepage keeping in mind the navbar and the footer so that it works properly. I have modified only one file for that.

Here's the demo:

https://github.com/dakshsinghrathore/ISRO-web/assets/132741672/da986b42-6920-44a0-9adc-20c38d0b7c05

Since this issue is not assigned to anyone at the moment. Can you please assign it to me?

rohits-web03 commented 1 year ago

Hello! I would love to contribute to your project for the issue #22.

I have implemented the snap-scroll effect on the ISRO-web homepage keeping in mind the navbar and the footer so that it works properly.

Here's the demo:

ISRO-web.homepage.snap-scroll.mp4

Since this issue is not assigned to anyone.Can you please assign it to me?

I can also improve the snap-scrolling effect further considering mobile devices(or any device with a touchpad).

Basically on a device with touchpad if we try to scroll through all sections with a single swing,then by default it tries to scroll past as many sections as possible and then stops but if you want that the user should go section by section while going through the website then I can make that happen as well.So that if the user tries to try to scroll through all sections with a single swing(on mobile) then the scroll would stop and snap on the next section and continue like that for next sections as well.

dakshsinghrathore commented 1 year ago

@rohits-web03 Assigned it to you !!

dakshsinghrathore commented 1 year ago

@sidhartha2002 Will assign you a different issue which you can work on shortly !

rohits-web03 commented 1 year ago

Hello! I would love to contribute to your project for the issue #22.

I have implemented the snap-scroll effect on the ISRO-web homepage keeping in mind the navbar and the footer so that it works properly.

Here's the demo:

ISRO-web.homepage.snap-scroll.mp4

Since this issue is not assigned to anyone.Can you please assign it to me?

I can also improve the snap-scrolling effect further considering mobile devices(or any device with a touchpad).

Basically on a device with touchpad if we try to scroll through all sections with a single swing,then by default it tries to scroll past as many sections as possible and then stops but if you want that the user should go section by section while going through the website then I can make that happen as well.So that if the user tries to try to scroll through all sections with a single swing(on mobile) then the scroll would stop and snap on the next section and continue like that for next sections as well.

for mobile devices do you want the default behaviour or want the user to go through the website section by section if they try to scroll through all sections with a single swing?

dakshsinghrathore commented 1 year ago

section by section !

rohits-web03 commented 1 year ago

I have made the changes.Can you please check my pr and merge it.

dakshsinghrathore commented 1 year ago

Yes, will review it shortly, your patience is appreciated 😃