search

dalab / deep-ed

Source code for the EMNLP'17 paper "Deep Joint Entity Disambiguation with Local Neural Attention", https://arxiv.org/abs/1704.04920
Apache License 2.0
223 stars 50 forks source link

updating num_positive_words_this_iter once you get random word #3

Open kanihal opened 7 years ago

kanihal commented 7 years ago

updating num_positive_words_this_iter once you get random word

kanihal commented 7 years ago

I'm following the exact instruction that is mentioned in the readme of this repo without any modification in the dataset whatsoever, The branch is getting reached quite a lot of times and used to crash there. That's how I found out the variable needs to be updated.

The script data_gen/gen_p_e_m/gen_p_e_m_from_yago.lua used to crash because of % issue not handled properly in LUA52, hence I made another pull request #4 . Does this modification have any effect on control reaching to the branch above?