search

dalanicolai / image-roll.el

Virtual scroll display engine for Emacs
80 stars 4 forks source link

Implement change page hooks #7

Closed yantar92 closed 2 years ago

yantar92 commented 2 years ago

Related to my other report #pdf-tools/4, I'd like to add hooks triggered by changing current page.

dalanicolai commented 2 years ago

Thanks for this PR, it looks good in general. Could you please address the comments? I will be happy to merge it!

dalanicolai commented 2 years ago

Now that I am looking again, I see that my question about the prog1 was not so clever, because the cond is inside the if of course. Anyway, your last/newest commit does not really address the 'run-hooks' indentation (I guess plain Emacs uses a different indentation setting than Spacemacs, but we should not mix it up), but I have cherry-picked your first commits and then added another commit to fix the indentation.

Thanks for contributing. If you find more, contributions are always very welcome!