search

dalapo / FactoryTech

Factory Tech, a tech mod centered around automatic maintenance of machines
1 stars 2 forks source link

Crafttweaker support maybe has broken. #73

Open TeetoKaziim opened 6 years ago

TeetoKaziim commented 6 years ago

After updating to the newest Factory Tech release on curseforge (1.4) every line of my zenscript file for the mod throws some kind of error.

My script file: https://gist.github.com/TeetoKaziim/426d6e0f545eddf8a95dae551a843570

The excerpt from the crafttweaker.log where loading this file happens: https://gist.github.com/TeetoKaziim/528b46efa62a12b698c2f90a12101026

Thanks for your time and consideration, mod's rad :D

dalapo commented 6 years ago

Newly in 1.4 you need an extra boolean value to specify whether the recipe works with a machine using stone parts.

TeetoKaziim commented 6 years ago

I ... see now, it's askin me for a bool in those. In most of those anyway.

I'm sorry, I need to read more carefully.

However, after adding the bools to everything, I noticed that in the original log, for my recipe on line 2, it said:

[INITIALIZATION][CLIENT][ERROR] factorytech_recipes.zs:2 > No such member: Agitator

So I added some bools to everything, and loaded my game up. AND IT WORKS... If I comment out my agitator recipe. If I DON'T comment out my agitator recipe, it does not work:

Script: https://gist.github.com/TeetoKaziim/02366f8e188fc2f90a75942e0a54f13c

Log: https://gist.github.com/TeetoKaziim/86296537f48b6cdfd1763986b76195f7

dalapo commented 6 years ago

Ah, I think for the Agitator, the boolean has to come between the inputs and the outputs. This was done to have a clean separation between them and prevent ambiguity.

dalapo commented 6 years ago

Actually, sorry, that's wrong. It does take a value between the inputs and the outputs, but it's just an int that's not used for anything other than distinguishing them.

TeetoKaziim commented 6 years ago

So I was about to say "I'm really at a loss here. Could you maybe show me an example of a valid recipe?", but then I thought to dig around in my debug.log and stumbled onto:

https://gist.github.com/TeetoKaziim/955327b2c5fbfb6140ddd3c8ad8379bb

Which not only reveals the "correct" layout of an agitator recipe, but also, apparently, crafttweaker doesn't like optional arguments in the middle of the method declaration? Which seems to be causing issues in your format for agitator, centrifuge, and magnetic centrifuge methods.

Sorry to be a gnat in your ear <.<

I was going to post the full log, but, it was 750,000 lines long and 98 MB? It's being spammed up but hard, by some other mod. Gist didn't like it.