search

daledavies / moodle-tool_registrationrules

GNU General Public License v3.0
2 stars 1 forks source link

rule_base::extend_form() should be renamed to something like extend_registration_form() #13

Open daledavies opened 1 month ago

daledavies commented 1 month ago

This will be consistent with the naming of extend_settings_form().

phager-at commented 1 month ago

:+1:

phager-at commented 1 month ago

It'd be much clearer and give us the possibility to extend with other methods to extend other forms too.

muellerlukas commented 1 month ago

Other callbacks like "extend_forgot_password_form" also just get passed the $mform variable. Maybe go for something like "extend_mform($mform)" so we keep it a little flexible and don't need a function for every form.