daledesilva / obsidian_ink

Other
265 stars 6 forks source link

Unable to insert handwriting section #14

Closed tripp396 closed 3 months ago

tripp396 commented 3 months ago

First, love the idea of this plugin. Something I’ve wanted for a while.

Here is the issue I am facing. When inserting a new handwriting section, nothing happens. I assumed there was some weird plugin compatibility issue so I started a brand new vault with no other plugins except BRAT, slash commander, and ink. Still having the same issue. Behavior is I click to add the section and it just goes back to my normal cursor.

I should have the latest version as I just installed this morning. Told BRAT to update it and restarted obsidian and still not able to do it.

Let me know if there are logs I can grab or anything else that can help.

anchoo2kewl commented 3 months ago

I have the same issue! Tried on my Mac and the iPad! The slash command shows them but does not do anything when invoked!

ichmoimeyo commented 3 months ago

I am having the same issue.

I opened brand new totally empty different vaults on an Android phone, a Linux Crostini Chromebook and a Windows 11 PC.

I installed Ink manually by creating an "Ink" folder in the .obsidian/plugins folder and then downloading into it: main.js manifest.json styles.jss

Using both ctrl+p and the slash command I tried ...

Insert new handwriting section Insert existing handwriting section

... neither of them worked in the current 0.1.15 or previous 0.1.1

However in the original 0.1.0 I could get it to work using

https://github.com/daledesilva/obsidian_ink/issues/9#issue-2218564520

"Insert New..." Creates the block but does not show it in the note. Immediately doing "Insert Existing..." shows that the block was created, and selecting it makes it show up in the UI

So I have reverted to the original 0.1.0 for the time being so that I can continue using INK.

@daledesilva - a huge thanks for developing this :)

daledesilva commented 3 months ago

Thanks for reporting everyone. For anyone that hasn't already, please go to the community plugins tab in settings and let me know the version of ink you're on just to be sure.

Also please let me know the version of obsidian) I think that's in the general tab).

Here's two things to try to help figure this out:

  1. Check if the ink files are being created in your vault when you run the commands, even though they're not appearing in the note.

  2. Try going to the files and folders tab in settings and changing the default attachment folder. Try the different folder location settings available and see if any work.

Thank you! We'll figure this out!!

anchoo2kewl commented 3 months ago

My version of ink: 0.1.15 Version of Obsidian: 1.5.12 I don't see any files or other assets being created in my vault!

tripp396 commented 3 months ago

I also do not see any other files added to the vault.

- Alex


From: Anshuman Biswas @.> Sent: Thursday, April 4, 2024 5:53:39 PM To: daledesilva/obsidian_ink @.> Cc: Alex Tripp @.>; Author @.> Subject: Re: [daledesilva/obsidian_ink] Unable to insert handwriting section (Issue #14)

My version of ink: 0.1.15 Version of Obsidian: 1.5.12 I don't see any files or other assets being created in my vault!

— Reply to this email directly, view it on GitHubhttps://github.com/daledesilva/obsidian_ink/issues/14#issuecomment-2038406286, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJEZW6LYPXI5LR7657AJRO3Y3XKXHAVCNFSM6AAAAABFXKFYNSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZYGQYDMMRYGY. You are receiving this because you authored the thread.Message ID: @.***>

daledesilva commented 3 months ago

Thanks all. Anyone who's on a laptop or desktop, could you please open dev tools (in chrome it's cmd+opt+j).

Then please try the insert hand written section and please take a screenshot of any errors that appear in the console after running that.

ichmoimeyo commented 3 months ago

In a nutshell: As opposed to release 0.1.0, in release 0.1.15 no "undefined" folder is created automatically and one has to set/verify: Default location for new attachments for Ink to work.

I created 2 new vaults ... I. myInk_0.1.0 using the original Ink 0.1.0 release It worked flawlessly out of the box as it created an undefined folder automatically. I didn't even have to use the https://github.com/daledesilva/obsidian_ink/issues/9#issue-2218564520 workaround. Screenshot 2024-04-04 15 56 29

II. myInk_0.1.15 using the Ink 0.1.15 release Out of the box it did not work at all because no attachment folder is created automatically Screenshot 2024-04-04 15 42 59 I changed ... Default location for new attachments ... in the folder specified below: ... Attachment folder path: myInkFolder and it worked correctly Screenshot 2024-04-04 16 47 19 I changed ... Default location for new attachments ... same folder as current file BUT instead ... ... a new folder called "Ink" was created that was not in the "new Folder" Screenshot 2024-04-04 16 09 39 I changed ... Default location for new attachments ... in subfolder under current folder BUT Obsidian didn't let me change the setting, instead ... ... it used the same "Ink" folder created earlier.(i.e. not in a subfolder under the current "new Folder 2") Screenshot 2024-04-04 18 06 26 I changed ... Default location for new attachments changed back to ... ... in the folder specified below: myInkFolder Screenshot 2024-04-04 16 23 58

\\

As opposed to release 0.1.0, in release 0.1.15 no "undefined" folder is created automatically and one has to set/verify: Default location for new attachments for Ink to work :) Screenshot 2024-04-05 06 43 29

My preferred location for attachments:

Default location for new attachments: in the folder specified below: 
Attachment folder path: myInkFolder

e.g.

handwritten-ink
{
    "versionAtEmbed": "0.1.15",
    "filepath": "myInkFolder/Ink/Writing/2024.3.4 - 14.07am.writing"
}

version of ink: 0.1.15 Version of Obsidian: 1.5.12

Successfully tested on ... Android Phone (both finger & inbuilt moto g stylus) Chromebook Linux Crostini with inbuilt Wacom EMR stylus Chromebook Linux Crostini with Capacitive Meko Stylus Chromebook chrome OS Android with Capacitive Meko Stylus Windows 11 PC NON-touch screen using mouse cursor(awkward obviously)

tripp396 commented 3 months ago

Tried this and it works! I selected in subfolder under current folder and named the Folder ink and then was able to start writing

anchoo2kewl commented 3 months ago

Works for me as well!

daledesilva commented 3 months ago

Thanks for all the trials @ichmoimeyo !! And thanks for following up to verify @tripp396 and @anchoo2kewl I've figured out what the issue is. I added in a check if the attachment folder path included './' but it seems that if you've never changed the attachment folder before then obsidian reports it as an undefined object... so previously it created a folder called undefined, but now since I try and check the text in the path, the error occurs.

This is an easy fix so I'm doing it now. I'll have a look into the "same folder as file" stuff too.

As a side note, the folder 'Ink' will always be created. This is so that the plugin can create extra files if needed and always keep them organised and separate from other attachments or files.

Thanks for reporting and testing everyone!

daledesilva commented 3 months ago

Okay... These issues should be fixed in 0.1.172 Please confirm once updated :)

ichmoimeyo commented 3 months ago

Thanks :) All working correctly in accordance with Default location for new attachments

Default location for new attachments (default): Vault folder ... a new folder called "Ink" was created Screenshot 2024-04-06 01 31 31 Default location for new attachments ... in the folder specified below: ... Attachment folder path: attachments Screenshot 2024-04-06 01 38 00 Default location for new attachments ... Same folder as current file Screenshot 2024-04-06 01 40 26 Default location for new attachments ... in subfolder under current folder ... Subfolder name: attachments Screenshot 2024-04-06 01 42 23 ... UPDATE: also working fine on my Android phone(Moto g Stylus) Screenshot_20240406-072917

daledesilva commented 3 months ago

Thanks for testing thoroughly