search

daleharvey / pacman

HTML5 Pacman
Do What The F*ck You Want To Public License
697 stars 470 forks source link

conflict with jQuery #8

Open kimas-m opened 9 years ago

kimas-m commented 9 years ago

when I use your code with some simple (fadeI; fadeOut) jQuery i get "undefined is not a function" it points to this line "var collection = ( tweeners[ prop ] || [] ).concat( tweeners[ "*" ] )," on jQuery. It works when i dont use any of game code. How to solve this problem because i want to use jQuery code too

dinc5150 commented 7 years ago

@kimasgold Did you find a way around it, so that you could use jQuery?

dinc5150 commented 7 years ago

Added pull request to fix this issue #14

kimas-m commented 7 years ago

Yes I think i found a way around it, that it wont interfere with jquery. Just now i cant remember this at all. sorry. back then i was frustrating on this matter. but i can see you found a way to fix it too.

dinc5150 commented 7 years ago

Thanks @kimasgold . Yes, I a "Clone" method added to the Object.prototype and jQuery was having issues with the function being added to all objects. As the method was only ever used once in the code, I simply changed to to be a standalone method and passed the object to it. All my jQuery animations are now working fine with the update.

johannesE commented 7 years ago

Please merge this. Because of this, I fucked up my production environment on April 1st. 🙄 Should have done proper testing..