search

dalehenrich / filetree

Monticello repository for directory-based Monticello packages enabling the use of git, svn, etc. for managing Smalltalk source code.
https://github.com/CampSmalltalk/Cypress
MIT License
133 stars 26 forks source link

fix MCFileTreeWriter to avoid failing tests #103

Closed demarey closed 11 years ago

frankshearar commented 11 years ago

I'm not sure what you're trying to do here. You move the implementation of #addString:at:encodedTo: to `#addString:at:, but to what end? I suppose I'm wondering what the exact nature of the problem is that you're trying to solve. Which tests fail? Why?

dalehenrich commented 11 years ago

@demarey prior to this merge request the previous test had 36 failures and the results for this pull request is 20 failures ... so I will go ahead and merge this pull request in.

Besides the git repo failures there are two tests that need to be addressed:

    MCFileTreeLoaderTraitsTest debug: #testLoad.
    MCFileTreeIssue92Test debug: #testWriteNRead.

The rest of the tests are GitRepository tests and I'm not sure that @ThierryGoubier has gotten that code ported to pharo3.0, yet (or perhaps because of the brokenness on travis, the fixes haven't been pushed yet)...If Thierry hasn't ported yet, I will turn off the gitrepo tests until Thierry has had a chance to fix them up ... need the base FileTree to work first:)

dalehenrich commented 11 years ago

@frankshearar we are struggling to reconcile the difference between test results on travis and test results on jenkins, this was one of the differences ... when we can get the tests to be green (for the first time ever) we'll worry about bringing the code back into alignment with the other platforms.

ThierryGoubier commented 11 years ago

@dalehenrich gitfiletree is failing on pharo3.0 because OSProcess is not working anymore on pharo3.0 (the platform selection code OSProcess relies on has been deprecated). I expect that a new OSProcess version will solve that and will see what I can do about it.