Git command not found

[ThierryGoubier]

On some platforms, the git command may not be in the path of the OSProcess commands (for example, git command inside /usr/local/bin and /usr/local/bin not in the default PATH).

Need a way to set additional paths to the git command used by FileTree-Git.

[krono]

This could also fix it on Windows. Have a look at metacello-git which currently works on windows/linux

[ThierryGoubier]

Thanks @krono. I had a look at the metacello-git project some time ago.

[ThierryGoubier]

Solved with a refactoring of the git commands on branch issue_142: commit 6c9598ac08c8f1d7ad891a917e1373da2b241d20

But the settings code is Pharo-specific :(

[krono]

On 10.02.2015, at 23:30, Thierry Goubier notifications@github.com wrote:

Solved with a refactoring of the git commands on branch issue_142: commit 6c9598a

But the settings code is Pharo-specific :(

For Squeak, a Pragma-preference would fit! :)

[ThierryGoubier]

Something like that ?

<preference: 'Git Command Path'
        category: 'monticello'
        description: 'The complete path for the git command, if not in the default PATH and different in name'
        type: #String>

This is interesting. One of the advantages of Pragmas is decoupling for extensions, but, it makes one unable to have a utility class hiding differences between Squeak and Pharo... or at least very hard to.

[krono]

Yes, something like that.

I understand :) We probably can find a way around that. For example, have the preferences in the specific utility implementations.

Like have the accessor for such things on MetacelloPlatform but the actual preferences in MetacelloSqueakPlatform and MetacelloPharoPlatform…

[ThierryGoubier]

@krono , does it matter in which method I put the Squeak preference pragma? I would like to add it to the Pharo settings method.

[krono]

You can put it directly in MCFileTreeGitRepository class >>#gitCommand:

gitCommand
    <preference: 'Git Command Path'
        category: 'monticello'
        description: 'The complete path for the git command, if not in the default PATH and different in name'
        type: #String>
    ^ GitCommand ifNil: [ 'git' ]

[ThierryGoubier]

Done in c77e84e04faf2007ec4e1cd196cd634dfd2b6935

Now I can tackle issue #142