New reader & repo following Cypress

dalehenrich / filetree

Monticello repository for directory-based Monticello packages enabling the use of git, svn, etc. for managing Smalltalk source code.

https://github.com/CampSmalltalk/Cypress

MIT License

133 stars 26 forks source link

New reader & repo following Cypress #151

Closed cdlm closed 6 years ago

cdlm commented 9 years ago

This PR is work in progress, for code review. Cleanup and more stuff needed before it gets merged.

[x] new MC repository type specific to Cypress layout
[x] new MCFileTreeReader with code extracted and refactored from MCFileTreeStCypressReader
[x] split/rename all the load/add methods to make the format policies more obvious, and the code more declarative
[ ] MCFileTreeWriter
[ ] proper testing

davelab6 commented 8 years ago

Is this PR ready for final review?

dalehenrich commented 8 years ago

... @cdlm if it is, ping me

cdlm commented 8 years ago

no… I had some initial results but I haven't touched it in a year.

I think the reading works (or is a 80% towards it) but writing doesn't exist yet, and I was not sure about the code structure and interaction with the monticello classes.

dalehenrich commented 6 years ago

with Tonel coming into play there is no need for a Cypress-based reader/repo