search

dalehenrich / filetree

Monticello repository for directory-based Monticello packages enabling the use of git, svn, etc. for managing Smalltalk source code.
https://github.com/CampSmalltalk/Cypress
MIT License
133 stars 26 forks source link

GitFileTree does not work anymore after Pharo 50558 #174

Closed marianopeck closed 8 years ago

marianopeck commented 8 years ago

Hi @ThierryGoubier

As for Pharo 50558 the startUpList: and shutdownList have been deprecated and now there is another way. For OSSubprocess project, I did this workaround:

initialize
    self initializeVMProcessInstance. 
    self flag: #removeIt.
    "This IF will be eliminated soon...only here temporary"
    (SystemVersion current highestUpdate >= 50558)
        ifTrue: [ 
            SessionManager default registerToolClassNamed: self name
             ]
        ifFalse: [ 
            Smalltalk addToStartUpList: OSSVMProcess.
            Smalltalk addToShutDownList: OSSVMProcess.
        ]

Could you please fix that in GitFileTree? It is failing for example with ProcessWrapper.

ThierryGoubier commented 8 years ago

I think this is an issue with ProcessWrapper.

ThierryGoubier commented 8 years ago

I wrote an email to Hernán for an update to ProcessWrapper

ThierryGoubier commented 8 years ago

Ok, and OSProcess needs that change as well.

marianopeck commented 8 years ago

Yes.... BTW, once we have #175 fixed , I guess I will need to merge that (pharo5.0_dev) into branch issue_171, right?

ThierryGoubier commented 8 years ago

This was fixed in ProcessWrapper and OSProcess