dalehenrich / filetree

Monticello repository for directory-based Monticello packages enabling the use of git, svn, etc. for managing Smalltalk source code.
https://github.com/CampSmalltalk/Cypress
MIT License
133 stars 26 forks source link

Adding new gitfiletree directory in Pharo 5 does not work #202

Closed JurajKubelka closed 8 years ago

JurajKubelka commented 8 years ago

Steps to reproduce:

  1. Open Catalog Browser,
  2. Install GitFileTree,
  3. Open Monticello Browser,
  4. Click +Repository button,
  5. Click gitfiletree:// and choose a directory with your git project,
  6. A debugger appears.

Environment information:

The reason is that there is no OSSUnixSubprocess:

runGitCommand: anArrayOfStrings in: aDirectory
    "..."
    Smalltalk at: #OSSUnixSubprocess ifAbsent: [  ]
    "..."

This is called by:

isGitRepository: aDirectory
    "Check that we have a git repository"

    ^ (self
        gitCommand: #('rev-parse' '--is-inside-work-tree')
        in: aDirectory) substrings first = 'true'
JurajKubelka commented 8 years ago

If I first load the following script, it works:

Metacello new
    configuration: 'OSSubprocess';
    repository: 'github://marianopeck/OSSubprocess:master/repository';
    version: #stable;
    load.
ThierryGoubier commented 8 years ago

Hi @JurajKubelka , it seems to be an error within the baseline / configuration of gitfiletree in the catalog (and smalltalkhub). I'll update that.

ThierryGoubier commented 8 years ago

Hum, I can't see what is wrong. The baseline checks for OSProcess in the image; if not present it loads OSSubprocess. In which Pharo image were you loading it from the catalog?

JurajKubelka commented 8 years ago

@ThierryGoubier: I have tried it again in Pharo5.0, Latest update: #50761 and it works. Maybe some network issues were involved in the previous case. So you can likely close this issue.

ThierryGoubier commented 8 years ago

Ok, thanks.