dalehenrich / filetree

Monticello repository for directory-based Monticello packages enabling the use of git, svn, etc. for managing Smalltalk source code.
https://github.com/CampSmalltalk/Cypress
MIT License
133 stars 26 forks source link

[Squeak] `DirectoryEntryFile >> #readStreamDo:` shadowed #233

Open LinqLover opened 3 years ago

LinqLover commented 3 years ago

Referring to MonticelloFileTree-Core-dkh.67 which is loaded by default into the current Squeak Trunk. This extension method shadows the existing method DirectoryEntryFile >> #readStreamDo: from the built-in Files package:

https://github.com/dalehenrich/filetree/blob/28ab532548104ee38c55eaff8e8849ab3f595c5f/repository/MonticelloFileTree-Core.package/DirectoryEntry.extension/instance/readStreamDo..st

Is this method still required or can it be removed as Squeak already provides it? In the first case, maybe the patch should be added to the Files package directly to avoid issues, or at least it should be classified as a proper override method by adding -override to the method category.