search

dalek-cryptography / bulletproofs

A pure-Rust implementation of Bulletproofs using Ristretto.
MIT License
1.02k stars 218 forks source link

travisci failed at yoloproofs #293

Closed HaoXuan40404 closed 5 years ago

HaoXuan40404 commented 5 years ago

I found that the latest code at .travis.yml added FEATURES='yoloproofs'，but run cargo test --features='yoloproofs' will be failed

HaoXuan40404 commented 5 years ago

Like this image

hdevalence commented 5 years ago

Ah, thanks for noticing this.

The problem is that the development branch develop has the yoloproofs feature to enable the R1CS API, but because we don't want people to depend on it in the published crate yet, it's commented out in the main branch and the published crate. So I guess the CI is failing only on the main branch and still working on the develop branch, right?

HaoXuan40404 commented 5 years ago

Hah, you're right. I built it on develop, and it succeeds. Maybe FEATURES='yoloproofs' should be hidden at main?

hdevalence commented 5 years ago

Yes, I think so. That change should have been included in 08a713e885a6256d62ce244a9f61826238d51534 but it wasn't. I can commit it as a fixup commit.

hdevalence commented 5 years ago

Hopefully fixed in 4b9d2c9

HaoXuan40404 commented 5 years ago

Ok, thank you