search

dalek-cryptography / bulletproofs

A pure-Rust implementation of Bulletproofs using Ristretto.
MIT License
1.02k stars 218 forks source link

Curve v2 (on develop branch) #305

Closed cbeck88 closed 4 years ago

cbeck88 commented 4 years ago

Uprev curve25519-dalek to v2 and use matching rand and rand_core versions (matching current master)

We need this because we are using bulletproofs/develop branch (for no_std support) and we also need to uprev curve25519-dalek to v2 (because the old version has a build.rs and depends on byteorder, but we also have build-dependencies that turn on byteorder/std, breaking our no_std build)

cbeck88 commented 4 years ago

it appears that this breaks yoloproofs unless we will also uprev rand_core used in merlin crate

hdevalence commented 4 years ago

Hi, it looks like this might be a duplicate of https://github.com/dalek-cryptography/bulletproofs/pull/303 ?

oleganza commented 4 years ago

@cbeck88 thanks for bumping this issue. I went to fix #303, so we hopefully will fully migrate to v2 curve-dalek after CI finishes.

hdevalence commented 4 years ago

These changes are included in #303, thanks!