search

dalek-cryptography / bulletproofs

A pure-Rust implementation of Bulletproofs using Ristretto.
MIT License
1.02k stars 216 forks source link

Upgrade some dependencies #331

Closed eranrund closed 3 years ago

eranrund commented 3 years ago

Hi!

We have a project that links newer version of curve25519-dalek, sha3 and digest. This PR updates those. I haven't updated the version in Cargo.toml since I am not sure how you'd like to go about this if you choose to accept this PR. Unfortunately, due to a dependency on clear_on_drop which now uses llvm_asm!, the Rust toolchain version had to be upgraded.

Thanks and please let me know if there's anything I can help with to get this merged in!

eranrund commented 3 years ago

Ping? Any chance in getting this merged?

hdevalence commented 3 years ago

Hey, sorry for the delay. I missed a bunch of stuff in August because I had to evacuate from a wildfire.

eranrund commented 3 years ago

Hey, sorry for the delay. I missed a bunch of stuff in August because I had to evacuate from a wildfire.

Very sorry to hear you were affected by the fires, and I hope you and your close ones are doing well.

dunnock commented 3 years ago

Was about to submit similar request but then found this one is pending, any chance to merge this one in? Thanks!

isislovecruft commented 3 years ago

Hi @eranrund! Thanks for the PR.

It looks like similar changes to these were merged here. If you still need the warning suppression and the compiler upgraded, could you please make separate PRs for those issues?

eranrund commented 3 years ago

Thank you @isislovecruft, I think this is good enough.