search

dalek-cryptography / curve25519-dalek

A pure-Rust implementation of group operations on Ristretto and Curve25519
Other
894 stars 460 forks source link

Fix error for custom targets #510

Closed pinkforest closed 1 year ago

pinkforest commented 1 year ago

Fixes #508 Supercedes #509

Desired behaviour is to require explicit setting in case of custom targets and give our helpful error message.

Also clears out the unwrap for missing standard TARGET in case of being used in non-Cargo build system.

semenov-vladyslav commented 1 year ago

This RP does not fix #508. The logic is pretty much the same is before but with nicer error messages. The issue is that I can't set curve25519_dalek_bits. Maybe it's the issue with the tools that I'm using, and not with this crate though.

pinkforest commented 1 year ago

Referring back to: https://github.com/dalek-cryptography/curve25519-dalek/issues/508#issuecomment-1465050817

I suspect the custom build tools which are not part of Rust are not signalling the right cfg's to rustc as it works with standard rustc tooling.