dalek-cryptography / curve25519-dalek

A pure-Rust implementation of group operations on Ristretto and Curve25519
Other
867 stars 439 forks source link

Expand lints #530

Closed tarcieri closed 1 year ago

tarcieri commented 1 year ago

Adds a lints section to the top of lib.rs with the following:

#![warn(
    clippy::unwrap_used,
    missing_docs,
    rust_2018_idioms,
    unused_lifetimes,
    unused_qualifications
)]

warn is used instead of deny to prevent the lints from firing during local development, however we already configure -D warnings in CI so if any lint fails on checked-in code, it will cause a CI failure.

This commit also fixes or explicitly allows any current violations of these lints. The main ones were:

rozbb commented 1 year ago

These are all good lints imo. Ty