Implement `ff` and `group` traits - Rebased

dalek-cryptography / curve25519-dalek

A pure-Rust implementation of group operations on Ristretto and Curve25519

Other

867 stars 439 forks source link

Closed pinkforest closed 1 year ago

pinkforest commented 1 year ago

Did some quick git dark arts :magic_wand: to re-base #473 and resolve the merge conflicts

Couple of warnings needs to be still addressed

pinkforest commented 1 year ago

Should we shift the trait impls into separate file/s - these files are getting big as noted by @rozbb https://github.com/dalek-cryptography/curve25519-dalek/pull/473#pullrequestreview-1230570618

Also should we refer to the PrimeField#associatedconstant.S docs someway somewhere perhaps

tarcieri commented 1 year ago

Just to get it landed I'd propose keeping it close to #473 to simplify review.

Refactoring can happen in follow-up PRs.

rozbb commented 1 year ago

Thank you @tarcieri! Been extremely busy lately (proposing thesis). Also idk who did it but the 2-stage decompression trick is really slick.