search

dalek-cryptography / curve25519-dalek

A pure-Rust implementation of group operations on Ristretto and Curve25519
Other
867 stars 439 forks source link

Adapt to new types introduced in fiat-crypto 0.2 #566

Closed divergentdave closed 1 year ago

divergentdave commented 1 year ago

I have an outstanding PR that proposes some breaking changes to fiat-crypto, see mit-plv/fiat-crypto#1623. Briefly, it introduces new structures to replace different type aliases for each field element representation. Encoding this in the type system is intended to prevent misuse of functions that require "tight" preconditions on their inputs' ranges. I'm opening this PR for a future crate upgrade early, with a [patch.crates-io] stanza, to test out the breaking change, and for temporary use in fiat-crypto's integration tests. If this looks good, I can back out the patch stanza when fiat-crypto is released and mark it ready for review.

divergentdave commented 1 year ago

The new fiat-crypto version is out, so this is ready now.

pinkforest commented 1 year ago

Thanks :tada: - I'm benching this atm for any regressions - I noted there was no_std issue per above

tarcieri commented 1 year ago

@divergentdave can you rebase now that #572 has been merged?

dconnolly commented 1 year ago

🎉

tarcieri commented 1 year ago

Merging so we can get this in #574