search

dalek-cryptography / curve25519-dalek

A pure-Rust implementation of group operations on Ristretto and Curve25519
Other
853 stars 422 forks source link

Deprecate `BASEPOINT_ORDER` from pub API consts #581

Closed pinkforest closed 10 months ago

pinkforest commented 10 months ago

Deprecates BASEPOINT_ORDER from pub API constants

Redirect internally to avoid deprecation errors

pinkforest commented 10 months ago

Fixed - Forgot to rebase

marshallpierce commented 9 months ago

I have a use for this constant (I need to exponentiate a scalar by order - 2) -- would it be objectionable to un-deprecate this? Otherwise I'll need to construct my own copy of a constant, which would be a shame.

Edit: I found another way, never mind!

trevor-crypto commented 5 months ago

@marshallpierce what was the solution? :thinking: Just making your own constant?

marshallpierce commented 5 months ago

It turned out I was doing curve operations in a needlessly complex way. I don't have the details in front of me, but tl;dr I found a way to do what I needed to do using other public parts of the API.