search

dalek-cryptography / curve25519-dalek

A pure-Rust implementation of group operations on Ristretto and Curve25519
Other
853 stars 422 forks source link

missing author info and license files for curve25519-dalek-derive #589

Closed alexanderkjall closed 8 months ago

alexanderkjall commented 9 months ago

The readme file refers to license files that gives 404's here:

https://github.com/dalek-cryptography/curve25519-dalek/blob/main/curve25519-dalek-derive/README.md?plain=1#L189

Could I assume that the authors are the same as curve25519-dalek when packaging this for Debian?

rozbb commented 9 months ago

Good catch. I think it would be the people who contributed the crate. I'll make that PR and clarify things

rozbb commented 8 months ago

Update: the license files will be moved into the repo in https://github.com/dalek-cryptography/curve25519-dalek/pull/590

rozbb commented 8 months ago

Merged that PR. License files are now there. They don't have any copyright lines bc the author waived it. Feel free to reopen if this doesn't answer your question

tarcieri commented 8 months ago

Perhaps we should cut another crate release that includes these files?

alexanderkjall commented 8 months ago

It's not needed for my use case, but I'm still a bit unsure what I should document as copyright holders for the crate.

Would 'RustCrypto Developers' be good?

rozbb commented 8 months ago

How necessary is it to name a specific person? It seems like the field is freeform. So would Copyright 2023 work? I say this because I don't want to misrepresent the origin of the file, and placing "RustCrypto Developers" after a nonexistent copyright line is indistinguishable from claiming the whole thing was made by RustCrypto developers

tarcieri commented 8 months ago

You could say "Dalek Developers"

alexanderkjall commented 8 months ago

So copyright isn't about who created a piece of work, it rather about documenting who owns the copyright of the thing.

The reason I ask is that I don't fully understand what it means to "waive" ones copyright, I presumed it meant that they transferred their copyright to someone else, maybe to the group of developers who have built these crates, aka the RustCrypto Developers.

In a hypothetical scenario: If there was a pressing need to relicense this work under another license, who could do that?

tarcieri commented 8 months ago

@koute is the principal author of curve25519-dalek-derive