ed25519-dalek: hide secret in `SigningKey`'s `Debug` impl

dalek-cryptography / curve25519-dalek

A pure-Rust implementation of group operations on Ristretto and Curve25519

Other

885 stars 449 forks source link

ed25519-dalek: hide secret in `SigningKey`'s `Debug` impl #592

Closed tarcieri closed 11 months ago

tarcieri commented 11 months ago

Uses finish_non_exhaustive in lieu of printing the secret_key component of a SigningKey, only showing the corresponding verifying_key field which can be used to identify the public key.

Closes #591

tarcieri commented 11 months ago

Oh joy, we're getting hit by an unrelated nightly regression that misidentifies unused imports.

Let me open a separate PR for that. Edit: opened #593

tarcieri commented 11 months ago

Rebased. Hopefully that fixes the build.