dalek-cryptography / curve25519-dalek

A pure-Rust implementation of group operations on Ristretto and Curve25519
Other
853 stars 422 forks source link

benchmark selection on the command line seems partially broken #607

Open oconnor663 opened 7 months ago

oconnor663 commented 7 months ago

I don't know Criterion well enough to guess at why this is, but the following behavior seems weird. In x25519-dalek and ed25519-dalek I can run benchmarks as tests like this:

cargo bench --all-features -- --test

But running the same command in the curve25519-dalek subdirectory doesn't just run tests, it runs the benchmark suite. Also, adding a filter argument (e.g. cargo bench --all-features xxx) seems to affect what tests run, but it doesn't affect what benchmarks run. Is the benchmark harness in that subdirectory ignoring CLI arguments for some reason?