`curve25519_dalek::SubgroupPoint`: missing traits

dalek-cryptography / curve25519-dalek

A pure-Rust implementation of group operations on Ristretto and Curve25519

Other

885 stars 449 forks source link

`curve25519_dalek::SubgroupPoint`: missing traits #617

Open survived opened 8 months ago

survived commented 8 months ago

curve25519_dalek::SubgroupPoint does not implement certain traits, although it only wraps curve25519_dalek::EdwardsPoint which does implement these traits:

Zeroize
ConstantTimeEq
ConditionallySelectable
TryFrom<EdwardsPoint>

AaronFeickert commented 2 months ago

The ConstantTimeEq and ConditionallySelectable traits were implemented in #672.

The functionality to (attempt to) get a SubgroupPoint from an EdwardsPoint does already exist via into_subgroup, though not using a TryFrom.

It looks like Zeroize simply isn't implemented. I just opened #682 to do so.