search

dalek-cryptography / curve25519-dalek

A pure-Rust implementation of group operations on Ristretto and Curve25519
Other
850 stars 416 forks source link

curve: mark `ValidityCheck` trait as `allow(dead_code)` #625

Closed tarcieri closed 4 months ago

tarcieri commented 4 months ago

Recent nightlies have started emitting a dead code lint which is breaking the build: https://github.com/dalek-cryptography/curve25519-dalek/actions/runs/7873600894/job/21481401663?pr=624#step:4:152

tarcieri commented 4 months ago

Not sure that would fix it for the cargo test case, since it seems to actually be dead code. Per the comments, it's intended for debugging use, so it's not expected to have any usages.

Edit: notably the error here is occurring during cargo test: https://github.com/dalek-cryptography/curve25519-dalek/actions/runs/7873600894/job/21481401663?pr=624#step:4:152

rozbb commented 4 months ago

Ah ok then