search

dalek-cryptography / ed25519-dalek

Fast and efficient ed25519 signing and verification in Rust.
BSD 3-Clause "New" or "Revised" License
684 stars 227 forks source link

Fixed repoerted speedup/slowdown percentages in README benchmarks #297

Closed rozbb closed 1 year ago

rozbb commented 1 year ago

The fiat column percentages were previously calculated wrt the simd column, and not the u64column, which appears to be the base.

tarcieri commented 1 year ago

Sidebar: it might be worth looking at Bencher, which is designed to collect benchmarks both locally and in CI. I believe it's capable of generating auto-updating plots of how performance changes along with the code.

There's an open issue to add an adapter for iai which uses cachegrind to collect statistics that can be relatively stable even in CI environments.