search

dalek-cryptography / ed25519-dalek

Fast and efficient ed25519 signing and verification in Rust.
BSD 3-Clause "New" or "Revised" License
684 stars 227 forks source link

Fix variable names in the invariant description #313

Closed wiktor-k closed 1 year ago

wiktor-k commented 1 year ago

Previously the variable names referred to public and secret which do not exist. Update them to verifying_key and secret_key.

tarcieri commented 1 year ago

Oh interesting, seems like the main branch is red due to a newly introduced warning

tarcieri commented 1 year ago

Oh I see, this is the old repo. The new repo is at:

https://github.com/dalek-cryptography/curve25519-dalek/tree/main/ed25519-dalek

wiktor-k commented 1 year ago

Oh, I see, I think I just followed the links on cargo.io. I'll file the PR there ASAP. Thanks for help!

wiktor-k commented 1 year ago

I've replaced this PR with https://github.com/dalek-cryptography/curve25519-dalek/pull/573.

I guess the old homepage that I saw on crates.io is fixed in main and will eventually reach crates.io.

Thanks :wave: