dalek-cryptography / x25519-dalek

X25519 elliptic curve Diffie-Hellman key exchange in pure-Rust, using curve25519-dalek.
BSD 3-Clause "New" or "Revised" License
326 stars 132 forks source link

Add feature `getrandom` #113

Closed pinkforest closed 1 year ago

pinkforest commented 1 year ago

Fixes #85 Supercedes #103 by re-rolling the commit with Co-authored-by @cipriancraciun (it was targeting main branch)

Provides the new feature getrandom with convenience random() functions (naming aligned to other daleks)

pinkforest commented 1 year ago

Because the fix CI PR has not been merged

pinkforest commented 1 year ago

Thanks - Now - the docs in CI - it's failing pending this:

We can merge that first pls and then can rebase and merge this :)

pinkforest commented 1 year ago

Oh the minor doc nit fix was actually in #112 but anyways I fixed it here as well - should merge ok now.

pinkforest commented 1 year ago

I worry about people getting confused if we change the meaning of ::new so the 2nd makes sense - I'll update it

EDIT: Done it's ::random_from_rng(OsRng) and ::random() now :)

tarcieri commented 1 year ago

Works for me