search

dalek-cryptography / x25519-dalek

X25519 elliptic curve Diffie-Hellman key exchange in pure-Rust, using curve25519-dalek.
BSD 3-Clause "New" or "Revised" License
328 stars 133 forks source link

Removed "nightly" from default features #34

Closed rozbb closed 5 years ago

rozbb commented 5 years ago

I was using this crate and was surprised to have a compile error when switching to "stable". The error came from subtle trying to use a #![feature(...)] gate. I spent some time tracking down what was using subtle with the "nightly" feature flag set. I checked curve25519-dalek and ed25519-dalek and neither of them set "nightly" by default. I found it a bit surprising, then, that x25519-dalek was the culprit.

So, in keeping with curve25519-dalek, ed25519-dalek, subtle, and zkp, I think this should compile by default on "stable".

hdevalence commented 5 years ago

This looks good, thanks! The CI failure seems unrelated to your changes and instead related to the usual rand brokenness (https://github.com/rust-random/rand/issues/704)

hdevalence commented 5 years ago

Released as 0.4.5.