dalekjs / dalek-browser-chrome

[unmaintained] Chrome Browser bindings for DalekJS
MIT License
15 stars 9 forks source link

Chrome does not close automatically after tests have been executed #1

Open asciidisco opened 11 years ago

asciidisco commented 11 years ago

After updating to chromedriver 2, the browser doesn't close automatically, after the test run has been finished.

Maybe we need to add smth. like we did in dalek-browser-ie, saving the newly created process & killing it on our own.

asciidisco commented 11 years ago

Issue resolved. The browser plugin now keeps track of the already running chrome processes & closes the ones that the driver opened after the tests have been executed.

omarlopesino commented 10 years ago

I have that problem running the tests on chrome now. I'm using chrome remotely in Windows 7 from kubuntu.

asciidisco commented 10 years ago

@OmarMoper Yep, that is a windows related issue. Most probably the same thing that happend here: https://github.com/dalekjs/dalek-browser-ie/pull/11

Do you want to give porting the changes from the IE module, to this one, a try?